txtar: add UTF-8 test case in TestParse by saurabhgame · Pull Request #600 · golang/tools

saurabhgame · 2025-10-20T04:17:33Z

Adds a new test case for the txtar package to verify that:

Parse correctly handles UTF-8 characters in file contents.
Leading comment lines are preserved properly.
This improves test coverage for non-ASCII content and ensures
comment parsing works as expected.

gopherbot · 2025-10-20T04:28:37Z

This PR (HEAD: c276b0b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/712980.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-20T04:44:44Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712980.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-20T04:44:44Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/712980.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T18:40:37Z

Message from Michael Matloob:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712980.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-25T15:48:42Z

This PR (HEAD: 920f684) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/712980.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-30T18:41:15Z

Message from Michael Matloob:

Patch Set 3: Code-Review+2

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712980.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T19:31:47Z

Message from t hepudds:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712980.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T19:31:47Z

Message from t hepudds:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712980.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T19:40:29Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-30T19:22:45Z","revision":"f1081026aff0c528379d43e1644d31679b7d058e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/712980.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T19:48:47Z

Message from t hepudds:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/712980.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T19:48:48Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/712980.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T19:48:48Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712980.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-03T21:39:56Z

Message from Michael Matloob:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712980.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-16T18:41:49Z

Message from Michael Matloob:

Patch Set 5: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712980.
After addressing review feedback, remember to publish your drafts!

Adds a new test case for the txtar package to verify that: Parse correctly handles UTF-8 characters in file contents. Leading comment lines are preserved properly. This improves test coverage for non-ASCII content and ensures comment parsing works as expected. Change-Id: I3eff5e09f6c3c588ca817c36178c9a7bafaa4ea7 GitHub-Last-Rev: 920f684 GitHub-Pull-Request: #600 Reviewed-on: https://go-review.googlesource.com/c/tools/+/712980 Reviewed-by: Michael Matloob <matloob@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Jonathan Amsterdam <jba@google.com>

gopherbot · 2026-03-17T17:21:04Z

This PR is being closed because golang.org/cl/712980 has been merged.

saurabhgame and others added 2 commits October 20, 2025 09:44

Add test for UTF-8 txtar encoding

4dc3bc7

reverted unnecessary files

c276b0b

txtar: move UTF-8 test into TestParse table

920f684

saurabhgame changed the title ~~txtar: add UTF-8 and comment parsing test~~ txtar: add UTF-8 test case in TestParse Oct 31, 2025

gopherbot closed this Mar 17, 2026

Conversation

saurabhgame commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Oct 20, 2025

Uh oh!

gopherbot commented Oct 20, 2025

Uh oh!

gopherbot commented Oct 20, 2025

Uh oh!

gopherbot commented Oct 22, 2025

Uh oh!

gopherbot commented Oct 25, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Nov 3, 2025

Uh oh!

gopherbot commented Mar 16, 2026

Uh oh!

gopherbot commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

saurabhgame commented Oct 20, 2025 •

edited

Loading